You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All relative paths were resolved to current dir ./ even though they should be for example ../ on Windows 11 and it was caused because chunkInfo.fileName had backward slashes \ instead of forward slashes /. This caused broken builds.
Looks like normalize or relative doesn't work with backward slashes so the bug was fixed with replacing Windows separator with posix separator. On posix system it just replaces posix separator with posix sep again so Mac or Linux is not affected (I tested on Mac).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@jussirantala Could you try and recreate the issue in a test case or raise an issue with a minimal reproduction? I can't manage to get chunkInfo.fileName to contain a relative path as rollup prevents emitting files to relative paths. Is there another way to get relative filenames?
@jussirantala Could you try and recreate the issue in a test case or raise an issue with a minimal reproduction? I can't manage to get chunkInfo.fileName to contain a relative path as rollup prevents emitting files to relative paths. Is there another way to get relative filenames?
@askoufis I'll try to find time for that but what do you mean with rollup preventing emitting files to relative paths? You just need to have something being imported from a upper directory. For example you could import some classes in your styling file from ../internal/baseStyles but this bug changes the path to ./internal/baseStyles causing a broken build.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All relative paths were resolved to current dir
./even though they should be for example../on Windows 11 and it was caused becausechunkInfo.fileNamehad backward slashes\instead of forward slashes/. This caused broken builds.Looks like
normalizeorrelativedoesn't work with backward slashes so the bug was fixed with replacing Windows separator with posix separator. On posix system it just replaces posix separator with posix sep again so Mac or Linux is not affected (I tested on Mac).